NO TICKET: update water level feature field names#308
Merged
Conversation
chasetmartin
requested review from
jacob-a-brown,
jirhiker,
ksmuczynski and
marissafichera
Codecov Report✅ All modified and coverable lines are covered by tests. |
Collaborator
Author
|
This PR is for updating the standalone water-level-csv feature for uploading water level measurements taken at an existing well. The required fields and field names are largely the same as the optional water level section of the well-inventory-csv feature documented here: #307 |
jacob-a-brown
left a comment
jacob-a-brown
left a comment
Contributor
There was a problem hiding this comment.
Overall I think that it looks good, but per our work on the well inventory csv upload feature file, we should make it so that measurement_date_time is timezone-naive and that the backend will add a timezone offset.
jacob-a-brown
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context: